Fix setup_scala_testing_toolchain() classpaths
#1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bazel-contrib#1706. Removes the addition of the Scala version suffix to `*_classpath` argument labels in `setup_scala_testing_toolchain()`. To facilitate the fix: - Moves everything from `testing/deps.bzl` into `testing/testing.bzl` and removes the original `testing/deps.bzl` file. - Updates `repositories()` from `scala/scala_cross_version.bzl` to accept and return `None` as an argument. - Updates `examples/testing/multi_frameworks_toolchain/BUILD` to provide a reproduction and validation of the fix. After updating `multi_frameworks_toolchain/BUILD`, but before applying the fix, the `multi_framework_toolchain_example` test case broke in a similar fashion to bazel-contrib#1706: ```txt $ RULES_SCALA_TEST_ONLY=multi_framework_toolchain_example \ ./test_examples.sh running test multi_framework_toolchain_example ERROR: .../examples/testing/multi_frameworks_toolchain/BUILD:19:30: no such package '@io_bazel_rules_scala_org_specs2_specs2_fp_2_12_20_2_12_20//': The repository '@io_bazel_rules_scala_org_specs2_specs2_fp_2_12_20_2_12_20' could not be resolved: Repository '@io_bazel_rules_scala_org_specs2_specs2_fp_2_12_20_2_12_20' is not defined and referenced by '//:testing_toolchain_specs2_classpath_provider' ERROR: Analysis of target '//:testing_toolchain_specs2_classpath_provider' failed; build aborted: Analysis failed INFO: Elapsed time: 0.159s INFO: 0 processes. ERROR: Couldn't start the build. Unable to run tests ```
|
Important The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1706. Removes the addition of the Scala version suffix to
*_classpathargument labels insetup_scala_testing_toolchain().To facilitate the fix:
Moves everything from
testing/deps.bzlintotesting/testing.bzland removes the originaltesting/deps.bzlfile.Updates
repositories()fromscala/scala_cross_version.bzlto accept and returnNoneas an argument.Updates
examples/testing/multi_frameworks_toolchain/BUILDto provide a reproduction and validation of the fix.After updating
multi_frameworks_toolchain/BUILD, but before applying the fix, themulti_framework_toolchain_exampletest case broke in a similar fashion to #1706:Motivation
This was clearly a bug introduced earlier in the effort to make
rules_scalaBzlmod compatible in #1482. At the time I didn't understand the ramifications, and we didn't have tests to catch this specific case. Many thanks to @crt-31 for finding it and filing #1706 before the next major release.