Replace bazel_worker_java with bazel_worker_api #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicates `@bazel_worker_java//:worker_protocol_java_proto` to avoid `bazel_worker_java` using `rules_jvm_external` to update `@maven` dependencies: - bazelbuild/bazel-worker-api#7 (comment). Also updates `exclude_patterns` in `//tools` to ignore all dotfile directories. --- `rules_scala` doesn't need anything else from `@bazel_worker_java`, so this sidesteps the issue. The `.bazelbsp` directory generated by VS Code started producing errors from `./test_lint.sh`, precipitating the `exclude_patterns` changes.
|
@simuons It would be great to get this in, and then push a new v7.1.1 tag. |
simuons
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Duplicates
@bazel_worker_java//:worker_protocol_java_prototo avoidbazel_worker_javausingrules_jvm_externalto update@mavendependencies:Also updates
exclude_patternsin//toolsto ignore all dotfile directories.Motivation
rules_scaladoesn't need anything else from@bazel_worker_java, so this sidesteps the issue.The
.bazelbspdirectory generated by VS Code started producing errors from./test_lint.sh, precipitating theexclude_patternschanges.