Skip to content

Conversation

@shatee
Copy link
Contributor

@shatee shatee commented Mar 2, 2020

fix #100

Element ID changed to sequential number in GitHub Enterprise. (e.g. diff-0, diff-1 ...)
I changed to refer to data-anchor attribute instead.

and update fixture.

@berzniz
Copy link
Owner

berzniz commented Mar 2, 2020

That's for the update. I do not use GitHub Enterprise myself so this is very helpful.

I'll test that this works on the regular GitHub as well and merge.

Copy link

@Astat Astat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebarys
Copy link

sebarys commented Mar 5, 2020

Hi @berzniz
Is any chance to merge this during this week?

@berzniz
Copy link
Owner

berzniz commented Mar 5, 2020

Yes. I will merge this today and upload to the store for review. Just want to make sure it doesn't break for non-enterprise GitHub users.

In the meantime, you can clone shatee:fix-id and run it locally. Should take less than 10 minutes in total to have it running on your browser

@painhardcore
Copy link

painhardcore commented Mar 5, 2020

@berzniz can't make it to work :( cloned shatee's version
Used yarn build and then loaded to extensions

upd. Nevermind, NODE_ENV=production yarn build-chrome worked

@berzniz berzniz changed the base branch from master to fix_github_enterprise March 5, 2020 15:55
@berzniz berzniz merged commit 91d020c into berzniz:fix_github_enterprise Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chrome - TypeError: Cannot read property 'getElementsByClassName' of null

5 participants