Skip to content

Conversation

@wboult
Copy link

@wboult wboult commented Sep 19, 2021

This is quite simplistic and just uses style='none', happy to use a CSS class instead. It does mean that it would remove any other content that existed in style, but as it stands the element doesn't have any styles applied to it. Some of the nested divs do use style - e.g. the header of the diff file uses style="top: 60px !important; position: sticky;"

I was thinking with CSS classes they may be more likely to be overridden by Github code causing the diffs to reappear.

I can add an option to disable this feature if you want, let me know

Demo
Animation

@kopach
Copy link

kopach commented Oct 6, 2021

Nice feature! Personally, I would like to have this configurable in settings (or via some button next to input), so we keep backward compatibility. Also, personally, sometimes I still find it useful to have diff visible – I often use native browser search to find some info in diffs.
Another option to toggle this feature - use some special character in the beginning of input text e.g. > or - or maybe surround with quotes ", e.g. "manifest"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants