Rename `Command::write`

[alice-i-cecile]

What problem does this solve or what need does it fill?

This name is unclear: it actually evaluates the Command on the World.

What solution would you like?

Rename this to act, execute or apply.

[alice-i-cecile]

[11:04 PM]AbleHeathen: maybe to apply to go along with apply_deferred

[neithanmo]

Hi @alice-i-cecile I want to implement this.
looking at the code I found this, so the name is not entirely intuitive for what method does. is this what needs to be changed to either "execute" or "apply":

[Themayu]

@neithanmo That's the correct trait, yes. Bear in mind that existing implementations throughout Bevy's own code will need updating to match the new name.

EDIT: Just to weigh in on the name, I think apply works better than execute, since it falls in line with apply_deferred (formerly apply_system_buffers) from the ECS.

[neithanmo]

@neithanmo That's the correct trait, yes. Bear in mind that existing implementations throughout Bevy's own code will need updating to match the new name.

EDIT: Just to weigh in on the name, I think apply works better than execute, since it falls in line with apply_deferred (formerly apply_system_buffers) from the ECS.

I thought that execute would be due to the method's documentation, so thanks for the suggestion, i will change it to "apply" and update any other implementations/references to it throughout Bevy's code base.
i guess the crate version has to change as well to a major version, as this is a breaking one, right?

[Themayu]

i guess the crate version has to change as well to a major version, as this is a breaking one, right?

No, that's handled by the maintainers. The next major release will be 0.11, which is already in the Cargo.toml file.

[Selene-Amanita]

Apply also matches https://docs.rs/bevy/latest/bevy/ecs/system/struct.SystemState.html#method.apply

I wanted to add that EntityCommand needs to be changed to but I see it's already done in the PR 👍