Skip to content

Conversation

@stepancheg
Copy link
Contributor

Encountered it while implementing #11109.

@matiqo15 matiqo15 added C-Docs An addition or correction to our documentation A-Core labels Dec 28, 2023
Copy link
Member

@matiqo15 matiqo15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we add this comment to OrthographicProjection? I would likely look there if I encountered any issue with this.

@stepancheg
Copy link
Contributor Author

@matiqo15 I added comment in OrthographicProjection initially, but then decided it is more appropriate on Camera2dBundle, because OrthographicProjection can be used not only with 2D camera.

@matiqo15
Copy link
Member

Makes sense, but I still think we should at least mention it in OrthographicProjection so that we can point users in the right direction. Would like to get someone else's opinion on this.

Copy link
Contributor

@atlv24 atlv24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance we could instead change the culling behavior to cull stuff strictly behind the near plane and not also things on the near plane?

@stepancheg
Copy link
Contributor Author

@rodolphito I suspect that might be

  • fragile to minor changes the project
  • may result in visual artefacts due to float rounding

But I don't really know.

@TrialDragon TrialDragon added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 5, 2024
@TrialDragon
Copy link
Member

I believe this needs to have main merged in; it's try to run CI checks that aren't available it seems.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 18, 2024
Merged via the queue into bevyengine:main with commit 2c95391 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants