Fix Labels #1142
Closed
Fix Labels #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I didn't touch the TODO: use |
Contributor
|
Note that removing the labels afte entity despawn looks like also broken. Adding tests to this file would be good. |
Contributor
|
I propose this PR as an alternative which fixes some corner cases and tests them. Feel free to take the tests in case you want to take a different approach: #1152 |
Moxinilian
added
C-Bug
Member
|
Closing in favor of #1152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found two issues with Labels while trying to use them in a scene:
thread 'main' panicked at 'scene contains the unregistered type bevy_core::label::Labelslabel_entitieshash map so it remained empty