Skip to content

Conversation

@Victoronz
Copy link
Contributor

Objective

QueryIter::sort_unstable_by_key is missing.

Solution

Add QueryIter::sort_unstable_by_key.

Testing

Added the new method to existing test.

Changelog

Added QueryIter::sort_unstable_by_key.

@Victoronz Victoronz added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events P-High This is particularly urgent, and deserves immediate attention D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes D-Unsafe Touches with unsafe code in some way S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 26, 2024
@Victoronz Victoronz added this to the 0.14 milestone Jun 26, 2024
@Victoronz
Copy link
Contributor Author

Victoronz commented Jun 26, 2024

The docs, test and implementation of sort_unstable_by_key is the exact same as sort_by_key aside from the name, internal sort call and the respective docs changes, so should not present any risk.

@Victoronz Victoronz closed this Jun 26, 2024
@Victoronz Victoronz force-pushed the let-sort-unstable-by-key-join-the-release-party branch from bbbf9fd to 3a04d38 Compare June 26, 2024 23:04
@Victoronz Victoronz reopened this Jun 26, 2024
@Victoronz
Copy link
Contributor Author

(added missing doc mention on QuerySortedIter)

@alice-i-cecile alice-i-cecile removed the P-High This is particularly urgent, and deserves immediate attention label Jun 27, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 27, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 27, 2024
Merged via the queue into bevyengine:main with commit e813326 Jun 27, 2024
mockersf pushed a commit that referenced this pull request Jun 27, 2024
# Objective

`QueryIter::sort_unstable_by_key` is missing.

## Solution

Add `QueryIter::sort_unstable_by_key`.

## Testing

Added the new method to existing test.

## Changelog

Added `QueryIter::sort_unstable_by_key`.
zmbush pushed a commit to zmbush/bevy that referenced this pull request Jul 3, 2024
# Objective

`QueryIter::sort_unstable_by_key` is missing.

## Solution

Add `QueryIter::sort_unstable_by_key`.

## Testing

Added the new method to existing test.

## Changelog

Added `QueryIter::sort_unstable_by_key`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes D-Unsafe Touches with unsafe code in some way S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants