Skip to content

Refactor AsBindGroup to use a associated SystemParam. #14909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2024
Merged

Refactor AsBindGroup to use a associated SystemParam. #14909

merged 5 commits into from
Aug 25, 2024

Conversation

@tychedelia
Copy link
Member

Objective

Adding more features to AsBindGroup proc macro means making the trait arguments uglier. Downstream implementors of the trait without the proc macro might want to do different things than our default arguments.

Solution

Make AsBindGroup take an associated Param type.

Migration Guide

AsBindGroup now allows the user to specify a SystemParam to be used for creating bind groups.

@tychedelia tychedelia added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Feature A new feature, making something new possible labels Aug 24, 2024
IceSentry
IceSentry approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I think this solves a relatively niche problem so not entirely sure it's required but I personally like this solution.

alice-i-cecile
alice-i-cecile approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I quite like this too! Well-implemented, and a good use of existing tools.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide and removed C-Feature A new feature, making something new possible S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 25, 2024
@tychedelia
Copy link
Member Author

Great, this will help me rebase #14663 to be a little cleaner. One other thing I'd note is that this allows custom implementors to be a little smarter about caching their own bind groups.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 25, 2024
Merged via the queue into bevyengine:main with commit 1caa64d Aug 25, 2024
@tychedelia tychedelia mentioned this pull request Aug 25, 2024
Merged
bas-ie added a commit to bas-ie/bevy_ecs_tilemap that referenced this pull request Oct 25, 2024
@bas-ie
Use SystemParam for args to as_bind_group
c472648 
See: bevyengine/bevy#14909
@bas-ie bas-ie mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tychedelia @alice-i-cecile @IceSentry