Skip to content

Update taffy requirement from 0.5 to 0.6 #16135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update taffy requirement from 0.5 to 0.6 #16135

wants to merge 3 commits into from

Conversation

@mnmaita
Copy link
Member

@mnmaita mnmaita commented Oct 28, 2024

Objective

Solution

  • Added missing fields in taffy::style::Style struct.

Testing

  • TBD

@mnmaita
Copy link
Member Author

mnmaita commented Oct 28, 2024

Wondering if I should just do ..default() to fill in the new fields or if it's better to have all the fields explicitly in case there are future breaking changes that might affect the display of UI elements. Feedback will be much appreciated.

@rparrett
Copy link
Contributor

rparrett commented Oct 28, 2024

Existing PR over here: #15844

dependabot bot and others added 3 commits October 28, 2024 13:40
@dependabot @mnmaita
Update taffy requirement from 0.5 to 0.6
a54191f 
Updates the requirements on [taffy](https://github.com/DioxusLabs/taffy) to permit the latest version.
- [Release notes](https://github.com/DioxusLabs/taffy/releases)
- [Changelog](https://github.com/DioxusLabs/taffy/blob/main/RELEASES.md)
- [Commits](DioxusLabs/taffy@v0.5.0...v0.6.1)

---
updated-dependencies:
- dependency-name: taffy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@mnmaita
Adds new Style fields in UiRect::from_node()
caa0c4e
@mnmaita
Fix 'typo'
5ca999c
@mnmaita
Copy link
Member Author

mnmaita commented Oct 28, 2024

Oh! Thanks for the heads up @rparrett, I'll close this and the dependabot PR and reference that one.

@mnmaita mnmaita closed this Oct 28, 2024
@mnmaita mnmaita deleted the mnmaita/taffy-0.6 branch October 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mnmaita @rparrett