Skip to content

Require ContentSize on UiImage again #16138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2024
Merged

Require ContentSize on UiImage again #16138

merged 6 commits into from
Oct 28, 2024

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Oct 28, 2024 •
edited
Loading

Objective

The ContentSize requirement on UiImage got lost during merge conflict fixes, causing some images such as the icons on the game_menu example to disappear.

Fixes #16136

Solution

Require ContentSize on UiImage again.

@ickshonpe ickshonpe changed the title Uiimage fix Require ContentSize on UiImage again Oct 28, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 28, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 28, 2024
@ickshonpe ickshonpe mentioned this pull request Oct 28, 2024
Closed
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 28, 2024
@rparrett
Copy link
Contributor

Looks like the wrong ticket got linked in the description.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 28, 2024
Merged via the queue into bevyengine:main with commit e586701 Oct 28, 2024
29 checks passed
mockersf pushed a commit that referenced this pull request Nov 5, 2024
@ickshonpe @alice-i-cecile @mockersf
Require ContentSize on UiImage again (#16138)
c344231 
The `ContentSize` requirement on `UiImage` got lost during merge
conflict fixes, causing some images such as the icons on the `game_menu`
example to disappear.

Fixes #16136

Require `ContentSize` on `UiImage` again.

---------

Co-authored-by: Alice Cecile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@mnmaita mnmaita mnmaita approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.15

Development

Successfully merging this pull request may close these issues.

Content missing from font_atlas_debug, overflow_debug, and game_menu examples

5 participants

@ickshonpe @rparrett @alice-i-cecile @BenjaminBrienen @mnmaita