Skip to content

Conversation

@chescock
Copy link
Contributor

@chescock chescock commented Nov 6, 2024

Objective

Re-enable some tests in entity_ref.rs that are marked as #[ignore], but that pass after #14561.

Solution

Remove #[ignore] from those tests.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 6, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Testing A change that impacts how we test Bevy or how users test their apps labels Nov 6, 2024
Merged via the queue into bevyengine:main with commit a967c75 Nov 6, 2024
34 checks passed
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
# Objective

Re-enable some tests in `entity_ref.rs` that are marked as `#[ignore]`,
but that pass after bevyengine#14561.

## Solution

Remove `#[ignore]` from those tests.
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
# Objective

Re-enable some tests in `entity_ref.rs` that are marked as `#[ignore]`,
but that pass after bevyengine#14561.

## Solution

Remove `#[ignore]` from those tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants