Remove TODO and add docs about limitations of PlaybackMode::Once
#16769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
changed the title
PlaybackMode::Once
alice-i-cecile
added
A-Audio
alice-i-cecile
approved these changes
Dec 11, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good docs: this is definitely better than nothing. I think we should remove Once completely and default to Remove. If you can't reuse this and need to replace the component anyways, it doesn't really seem like there's a point.
alice-i-cecile
added
the
S-Needs-Review
BenjaminBrienen
approved these changes
Dec 11, 2024
Contributor
BenjaminBrienen
left a comment
BenjaminBrienen
left a comment
There was a problem hiding this comment.
I imagine that this documentation will be updated when the missing feature "bug" is implemented.
alice-i-cecile
added
S-Ready-For-Final-Review
Trashtalk217
pushed a commit
to Trashtalk217/bevy
that referenced
this pull request
Dec 21, 2024
…evyengine#16769) # Objective Fixes bevyengine#12359 ## Solution Implement alternative number 4. bevyengine#12359 (comment) > I don't think that I agree with the premise of this issue anymore. I am not sure that entities "magically" despawning themselves or components removing themselves make for great defaults in an "ECS-based API". This behavior is likely to be just as surprising to people. > > I think that the lack of sink re-usability should be treated as a bug and possibly the documentation improved to reflect the current limitations if it doesn't seem like a fix is forthcoming. > -- me
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…evyengine#16769) # Objective Fixes bevyengine#12359 ## Solution Implement alternative number 4. bevyengine#12359 (comment) > I don't think that I agree with the premise of this issue anymore. I am not sure that entities "magically" despawning themselves or components removing themselves make for great defaults in an "ECS-based API". This behavior is likely to be just as surprising to people. > > I think that the lack of sink re-usability should be treated as a bug and possibly the documentation improved to reflect the current limitations if it doesn't seem like a fix is forthcoming. > -- me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #12359
Solution
Implement alternative number 4.
#12359 (comment)