Skip to content

Conversation

@Victoronz
Copy link
Contributor

@Victoronz Victoronz commented Mar 11, 2025

Objective

Part of the #16547 series.

The entity wrapper types often have some associated types an aliases with them that cannot be re-exported into an outer module together.
Some helper types are best used with part of their path: bevy::ecs::entity::index_set::Slice as index_set::Slice.
This has already been done for entity::hash_set and entity::hash_map.

Solution

Publicize the index_set, index_map, unique_vec, unique_slice, and unique_array modules.

Migration Guide

Any mention or import of types in the affected modules have to add the respective module name to the import path.
F.e.:
bevy::ecs::entity::EntityIndexSet -> bevy::ecs::entity::index_set::EntityIndexSet

@Victoronz Victoronz added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Mar 11, 2025
@Victoronz Victoronz added this to the 0.16 milestone Mar 11, 2025
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 11, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 11, 2025
Merged via the queue into bevyengine:main with commit 32d53e7 Mar 11, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants