Remove parking_lot from bevy_asset and bevy_macro_utils
#18996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
A-Assets
9 tasks
|
Adopting this under #20630. Added @bushrat011899 as a co-author to that PR. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
# Objective Spend less time compiling what is already in the standard library. Remove `parking_lot` from first party crate dependencies. Contribute to #18978. Supercedes #18996. ## Solution Use `bevy_platform::sync` types wherever possible. `BevyManifest::shared` directly returned a mapped guard, but that could be circumvented by just using a scope-like API instead. The crate is still in the dependency tree, transitively, through `wgpu`, but is now no longer required for any non-rendering crates. ## Testing Ran tests locally. Co-Authored-By: Zac Harrold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
no_stdforbevy_asset#18978 by removing a dependency that is notno_stdcompatibleSolution
parking_lotfrombevy_assetand switched tobevy_platform::syncinternally.parking_lotfrombevy_macro_utilsand switched tostd::syncinternally. Also added a simple alternative to mappedRwLockguards while the feature is nightly-only.Testing
Notes
It is possible there is a performance change here, but I believe it will be negligible due to performance improvements in
stdsince Bevy adoptedparking_lotin #210. If there is a performance difference noticed, I believe the more appropriate course of action would be to moveparking_lotintobevy_platformas a feature, so that all parts of Bevy could benefit, not justbevy_asset.