Faster FilteredEntity(Ref|Mut) and Entity(Ref|Mut)Except by borrowing Access

crates/bevy_animation/src/animation_curves.rs

@@ -408,10 +408,7 @@ impl<A: Animatable> AnimationCurveEvaluator for AnimatableCurveEvaluator<A> {
         self.evaluator.push_blend_register(weight, graph_node)
     }
 
-    fn commit<'a>(
-        &mut self,
-        mut entity: AnimationEntityMut<'a>,
-    ) -> Result<(), AnimationEvaluationError> {
+    fn commit(&mut self, mut entity: AnimationEntityMut) -> Result<(), AnimationEvaluationError> {
         let property = self.property.get_mut(&mut entity)?;
         *property = self
             .evaluator
@@ -596,10 +593,7 @@ impl AnimationCurveEvaluator for WeightsCurveEvaluator {
         Ok(())
     }
 
-    fn commit<'a>(
-        &mut self,
-        mut entity: AnimationEntityMut<'a>,
-    ) -> Result<(), AnimationEvaluationError> {
+    fn commit(&mut self, mut entity: AnimationEntityMut) -> Result<(), AnimationEvaluationError> {
         if self.stack_morph_target_weights.is_empty() {
             return Ok(());
         }
@@ -905,10 +899,7 @@ pub trait AnimationCurveEvaluator: Downcast + Send + Sync + 'static {
     ///
     /// The property on the component must be overwritten with the value from
     /// the stack, not blended with it.
-    fn commit<'a>(
-        &mut self,
-        entity: AnimationEntityMut<'a>,
-    ) -> Result<(), AnimationEvaluationError>;
+    fn commit(&mut self, entity: AnimationEntityMut) -> Result<(), AnimationEvaluationError>;
 }
 
 impl_downcast!(AnimationCurveEvaluator);

crates/bevy_animation/src/lib.rs

@@ -1021,8 +1021,8 @@ pub fn advance_animations(
 }
 
 /// A type alias for [`EntityMutExcept`] as used in animation.
-pub type AnimationEntityMut<'w> =
-    EntityMutExcept<'w, (AnimationTarget, AnimationPlayer, AnimationGraphHandle)>;
+pub type AnimationEntityMut<'w, 's> =
+    EntityMutExcept<'w, 's, (AnimationTarget, AnimationPlayer, AnimationGraphHandle)>;
 
 /// A system that modifies animation targets (e.g. bones in a skinned mesh)
 /// according to the currently-playing animations.

crates/bevy_ecs/src/query/access.rs

@@ -165,6 +165,32 @@ impl<T: SparseSetIndex> Access<T> {
         }
     }
 
+    /// Creates an [`Access`] with read access to all components.
+    /// This is equivalent to calling `read_all()` on `Access::new()`,
+    /// but is available in a `const` context.
+    pub(crate) const fn new_read_all() -> Self {
+        let mut access = Self::new();
+        access.reads_all_resources = true;
+        // Note that we cannot use `read_all_components()`
+        // because `FixedBitSet::clear()` is not `const`.
+        access.component_read_and_writes_inverted = true;
+        access
+    }
+
+    /// Creates an [`Access`] with read access to all components.
+    /// This is equivalent to calling `read_all()` on `Access::new()`,
+    /// but is available in a `const` context.
+    pub(crate) const fn new_write_all() -> Self {
+        let mut access = Self::new();
+        access.reads_all_resources = true;
+        access.writes_all_resources = true;
+        // Note that we cannot use `write_all_components()`
+        // because `FixedBitSet::clear()` is not `const`.
+        access.component_read_and_writes_inverted = true;
+        access.component_writes_inverted = true;
+        access
+    }
+
     fn add_component_sparse_set_index_read(&mut self, index: usize) {
         if !self.component_read_and_writes_inverted {
             self.component_read_and_writes.grow_and_insert(index);