Skip to content

Update documentation of HitData coordinates range in ui::picking_backend #20465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2025
Merged

Update documentation of HitData coordinates range in ui::picking_backend #20465

merged 1 commit into from
Aug 9, 2025

Conversation

gwafotapa
Copy link
Contributor

HitData coordinates now lie between -0.5 and 0.5. The documentation of the ui::picking_backend module still documents the old values of 0.0 and 1.0.

@ickshonpe ickshonpe added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels Aug 8, 2025
@ickshonpe ickshonpe self-requested a review August 8, 2025 21:23
ickshonpe
ickshonpe approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the first time I forgot to update the module level docs after making a change 😓

@gwafotapa
Copy link
Contributor Author

@ickshonpe Some checks failed and I don't understand why. Did I do something wrong?

@ickshonpe
Copy link
Contributor

ickshonpe commented Aug 9, 2025 •
edited
Loading

@ickshonpe Some checks failed and I don't understand why. Did I do something wrong?

No nothing you did, it's a bug with the CI. If you merge with main it should fix itself.

@gwafotapa
Copy link
Contributor Author

Ok thanks.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 9, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 9, 2025
Merged via the queue into bevyengine:main with commit 1173f0d Aug 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@ickshonpe ickshonpe ickshonpe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Picking Pointing at and selecting objects of all sorts A-UI Graphical user interfaces, styles, layouts, and widgets C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gwafotapa @ickshonpe @alice-i-cecile