Skip to content

[Merged by Bors] - Clean up advice on glob imports in style guide #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Clean up advice on glob imports in style guide #4644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b4fa60
Clean up advice on glob imports in style guide
alice-i-cecile May 2, 2022
b1732d9
Update .github/contributing/engine_style_guide.md
alice-i-cecile May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/contributing/engine_style_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ For more advice on contributing to the engine, see the [relevant section](../../

## General guidelines

1. Prefer granular imports over glob imports of `bevy::prelude::*` and `bevy::sub_crate::*`.
1. Prefer granular imports over glob imports like `bevy_ecs::prelude::*`.
2. Use a consistent comment style:
1. `///` doc comments belong above `#[derive(Trait)]` invocations.
2. `//` comments should generally go above the line in question, rather than in-line.
Expand Down