Skip to content

do not reset is_visible for each camera #5020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

do not reset is_visible for each camera #5020

wants to merge 1 commit into from

Conversation

@mockersf
Copy link
Member

@mockersf mockersf commented Jun 15, 2022 •
edited
Loading

Objective

Solution

  • Move the is_visible reset outside of the camera loop, as it was before

@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jun 15, 2022
@mockersf mockersf force-pushed the fix-parallel-frustrum branch from 249fd08 to 20a8e09 Compare June 15, 2022 21:46
@mockersf mockersf mentioned this pull request Jun 17, 2022
Closed
hymm
hymm reviewed Jun 20, 2022
View reviewed changes
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 21, 2022
@mockersf
Copy link
Member Author

mockersf commented Jun 21, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 21, 2022

Merge conflict.

@hymm
Copy link
Contributor

hymm commented Jun 21, 2022

@james7132 snuck this fix into #4663

@mockersf
Copy link
Member Author

mockersf commented Jun 21, 2022

ha... nice I guess

@mockersf mockersf closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

+2 more reviewers

@hymm hymm hymm approved these changes

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

post_processing example does not work render to texture example is broken

4 participants

@mockersf @hymm @james7132 @IceSentry