Fix look_to resulting in NaN rotations #7817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
approved these changes
Feb 25, 2023
Contributor
nicopap
left a comment
nicopap
left a comment
There was a problem hiding this comment.
This is like Elm deciding that 1 / 0 = 0, it might not comply with the purely theoretical definition, but I personally think that functional beats pure. Especially if the selected fallback direction is clearly defined.
tim-blackbird
approved these changes
Feb 25, 2023
james7132
requested changes
Feb 25, 2023
| /// Returns this [`Transform`] with a new rotation so that [`Transform::forward`] | ||
| /// points towards the `target` position and [`Transform::up`] points towards `up`. | ||
| /// | ||
| /// In some cases it's not possible to construct a rotation. Another axis will be picked in those cases: |
Member
There was a problem hiding this comment.
I wonder if this means we should be returning Result<Self, SomeError> instead, seems odd to silently fail here.
Member
There was a problem hiding this comment.
IMO we're not silently failing: we're performing a "best-attempt". I'd be open to try variants too.
Member
Author
There was a problem hiding this comment.
I would prefer to work by default, instead of having to add unwrap / error management everywhere this pops up
alice-i-cecile
added
the
S-Ready-For-Final-Review
Co-authored-by: Liam Gallagher <[email protected]>
ProfLander
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Liam Gallagher <[email protected]>
ProfLander
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Liam Gallagher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
looking_atis called withTransform's origin as target #3736Transform::look_at()docs #6136Solution