[Merged by Bors] - Remove dead code after #7784 #7875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
added
A-Rendering
james7132
added
the
M-Migration-Guide
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
geieredgar
approved these changes
Mar 2, 2023
Contributor
There was a problem hiding this comment.
This looks good, I am sorry for missing that queue_shadow_view_bind_group doesn't do anything anymore and for not removing SetShadowViewBindGroup together with DrawShadowMesh. There is also another issue with my changes, for which I am currently writing a PR see #7878.
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
# Objective - Remove dead code after #7784 # Changelog - Removed `SetShadowViewBindGroup`, `queue_shadow_view_bind_group()`, and `LightMeta::shadow_view_bind_group` in favor of reusing the prepass view bind group. # Migration Guide - Removed `SetShadowViewBindGroup`, `queue_shadow_view_bind_group()`, and `LightMeta::shadow_view_bind_group` in favor of reusing the prepass view bind group.
Contributor
|
Timed out. |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
# Objective - Remove dead code after #7784 # Changelog - Removed `SetShadowViewBindGroup`, `queue_shadow_view_bind_group()`, and `LightMeta::shadow_view_bind_group` in favor of reusing the prepass view bind group. # Migration Guide - Removed `SetShadowViewBindGroup`, `queue_shadow_view_bind_group()`, and `LightMeta::shadow_view_bind_group` in favor of reusing the prepass view bind group.
Contributor
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2023
# Objective Unfortunately, there are three issues with my changes introduced by #7784. 1. The changes left some dead code. This is already taken care of here: #7875. 2. Disabling prepass causes failures because the shadow mapping relies on the `PrepassPlugin` now. 3. Custom materials use the `prepass.wgsl` shader, but this does not always define a fragment entry point. This PR fixes 2. and 3. and resolves #7879. ## Solution - Add a regression test with disabled prepass. - Split `PrepassPlugin` into two plugins: - `PrepassPipelinePlugin` contains the part that is required for the shadow mapping to work and is unconditionally added. - `PrepassPlugin` now only adds the systems and resources required for the "real" prepasses. - Add a noop fragment entry point to `prepass.wgsl`, used if `NORMAL_PASS` is not defined. Co-authored-by: Edgar Geier <[email protected]>
ProfLander
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
# Objective - Remove dead code after bevyengine#7784 # Changelog - Removed `SetShadowViewBindGroup`, `queue_shadow_view_bind_group()`, and `LightMeta::shadow_view_bind_group` in favor of reusing the prepass view bind group. # Migration Guide - Removed `SetShadowViewBindGroup`, `queue_shadow_view_bind_group()`, and `LightMeta::shadow_view_bind_group` in favor of reusing the prepass view bind group.
ProfLander
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
…yengine#7878) # Objective Unfortunately, there are three issues with my changes introduced by bevyengine#7784. 1. The changes left some dead code. This is already taken care of here: bevyengine#7875. 2. Disabling prepass causes failures because the shadow mapping relies on the `PrepassPlugin` now. 3. Custom materials use the `prepass.wgsl` shader, but this does not always define a fragment entry point. This PR fixes 2. and 3. and resolves bevyengine#7879. ## Solution - Add a regression test with disabled prepass. - Split `PrepassPlugin` into two plugins: - `PrepassPipelinePlugin` contains the part that is required for the shadow mapping to work and is unconditionally added. - `PrepassPlugin` now only adds the systems and resources required for the "real" prepasses. - Add a noop fragment entry point to `prepass.wgsl`, used if `NORMAL_PASS` is not defined. Co-authored-by: Edgar Geier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Changelog
SetShadowViewBindGroup,queue_shadow_view_bind_group(), andLightMeta::shadow_view_bind_groupin favor of reusing the prepass view bind group.Migration Guide
SetShadowViewBindGroup,queue_shadow_view_bind_group(), andLightMeta::shadow_view_bind_groupin favor of reusing the prepass view bind group.