Screenshots in wasm #8455
Merged
Screenshots in wasm #8455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
approved these changes
Apr 22, 2023
| html_element.click(); | ||
| web_sys::Url::revoke_object_url(&url)?; | ||
| Ok::<(), JsValue>(()) | ||
| })() { |
There was a problem hiding this comment.
The syntax for "try/catch" in rust is very unusual 🙂
There was a problem hiding this comment.
you... get used to it. and it provides nice scoping
alice-i-cecile
added
C-Feature
cart
reviewed
Apr 26, 2023
Comment on lines
+86
to
+95
| 'Blob', | ||
| 'Document', | ||
| 'Element', | ||
| 'HtmlElement', | ||
| 'Node', | ||
| 'Url', | ||
| 'Window', |
There was a problem hiding this comment.
Will including more web-sys features meaningfully affect our wasm build sizes?
There was a problem hiding this comment.
Just tried a build, it's 14kB smaller with this PR. Build duration were similar
There was a problem hiding this comment.
Amazing that it got smaller by adding features. Works for me
mockersf
force-pushed
the
screenshots-in-wasm
branch
from
94aa995 to
39f34f6
Compare
cart
approved these changes
Apr 28, 2023
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
aelement to the document linking to that url, click on that element, then revoke the url