-
-
Couldn't load subscription status.
- Fork 4.2k
Flatten UI Style properties that use Size + remove Size
#8548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, I think this is an improvement.
|
Love it, hated how pub struct LengthConstraint {
pub min: Val,
pub max: Val,
pub suggested: Val,
} but I much prefer this, just get rid of all the structure completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor things you can ignore if you like, the two broken links excepted.
|
@nicoburns are you doing a new generic |
I am not. This PR doesn't need a `Size. Feel free to work on that if you want to :) Taffy's may be good to copy if you want inspiration. |
|
@konsti219 want to review this PR? |
Yep copy from Taffy is exactly what I meant by "bash something together" 😄 |
Earliest I could get to this is tomorrow. But feel free to ping me in future PRs. |
|
I support ickshonpe's idea of changing |
Co-authored-by: ickshonpe <[email protected]>
Co-authored-by: ickshonpe <[email protected]>
Objective
See: #8540 (comment)
Solution
size,min_size,max_size, andgapproperties have been replaced bywidth,height,min_width,min_height,max_width,max_height,row_gap, andcolumn_gappropertiesChangelog
Styleproperties that have aSizevalue directly intoStyleMigration Guide
size,min_size,max_size, andgapproperties have been replaced by thewidth,height,min_width,min_height,max_width,max_height,row_gap, andcolumn_gapproperties. Use the new properties instead.