This repository was archived by the owner on Feb 7, 2024. It is now read-only.
[1.x] DnsResolver - incorrect return type fixed #979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: no entries in websockets_statistics_entries table.
How to reproduce:
Caused by incorrect return type from BeyondCode\LaravelWebSockets\Statistics\DnsResolver, resolve() must return string, resolveAll() - array.
Possible workaround - set config websockets.statistics.perform_dns_lookup to true, in that case BeyondCode\LaravelWebSockets\Statistics\DnsResolver will not replace default dns resolver.
Fix - change return type (which is made in this commit).
Required return types described in React\Dns\Resolver\ResolverInterface interface.