-
Notifications
You must be signed in to change notification settings - Fork 397
feat(payment): INT-2118 adding amazon pay option #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deov31 I have some comments for you, Could you please take a look and if you have any question please let me know. Also please fix the tests that are failing in circle ci 🔴 ♻️
|
Hi @clopezh, thanks for your comments. Can you please take a look again? Also, build continue failing due a missing field in |
clopezh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :+1
|
💚 Tested QA Details:
|
clopezh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deov31 Hello Fanny! I only have one comment, Could you please take a look?
|
Hi @clopezh I addressed your new comment. Can you please take a look again? ♻️ Thanks for the review. |
clopezh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thank you for addressing my requests 👍
|
@deov31 could you please take a look at the build errors? thanks! |
|
Hi @capsula4 the build error is caused due to the missing types on the current version of sdk on master. We created a new PR in sdk code but it points to a feature branch called amazon_maxo. I think we have two ways to fix this:
The build error is If you have any observation or recommendation, please let me know. |
|
Hi @capsula4, thanks for the review. I addressed your comments, can you please take a look again? ♻️ |
lpschz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the feedback! Looking better! Just one outstanding question around syncing the billing address to the API with the same information that the API actually returned.
|
Thanks again for the new comments @capsula4. I updated the PR based on your feedback. Can you please take a look again? ♻️ |
|
Hi @capsula4, I also made some changes to this PR because of the dependency with SDK, let us know any question you could have. Thanks! |
|
Hi @capsula4 I addressed your latest suggestions. Can you review again? ♻️ |
|
💚 Tested QA Details: Re-testing to validate changes from comments in PR. A couple of test cases where added.
|
- Render Amazon Pay as a HostedWidgetPaymentMethod - Introduces a new StaticAddressEditable component - Uses the new isShippingStepPending selector
INT-2118
INT-2188
What?
Why?
Per requeriment of this new amazonpay version it has to show static addresses on bigcommerce side because that step is made in an amazon page.
Testing / Proof
Demos Links
https://drive.google.com/open?id=1vOGKZCzkVa981zwpn4HbpjJ0ydXKhmi7
THIS PR DEPENDS ON ANOTHER PR IN CHECKOUT-SDK-JS #866
@bigcommerce/checkout @bigcommerce/apex-integrations