fix(payment): PAYPAL-2936 updated PayPal Commerce shipping callbacks with onShippingChanged #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-nick
approved these changes
Nov 15, 2023
andriiVitvitskyi1990
approved these changes
Nov 15, 2023
bc-dronov
approved these changes
Nov 15, 2023
…with onShippingChanged
serhii-tkachenko
force-pushed
the
PAYPAL-2936
branch
from
9c19eb1 to
ce5bb78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updated
onShippingAddressChangeandonShippingOptionChangecallbacks toonShippingChangein different PayPal Commerce strategies.Why?
PayPal Commerce Skip Checkout feature does not work properly for shoppers. This issue happens because several shipping callbacks was deprecated on PayPal side due to closing another project. Therefore we should come back to PayPal's documentation and make it works as it was before that project.
Testing / Proof
Unit tests
Manual tests