Skip to content

Conversation

@freedom9
Copy link

@binarywang
Copy link
Owner

感谢楼主提供PR,不过为了保证代码质量,建议加上单元测试代码,如果确实不方便编写,或无法测试,请给出自测成功的截图也可以

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 21, 2022

⚠️ 22 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@freedom9
Copy link
Author

image
由于一些参数不方便给出,只能给出成功截图。

@binarywang
Copy link
Owner

其实你是写了单元测试的吧,建议将敏感账号信息参数抽取成配置项,这样就可以把单元测试代码提交上来,方便其他人以后做测试验证

@binarywang binarywang merged commit 9b78acd into binarywang:develop Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants