rpcnestedtests.cpp:remove qtest-obsolete members #900
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
I will remove 4f29ddf if requested. |
| QVERIFY(result == "[\"abc\",\"cba\"]"); | ||
|
|
||
| // Handle deprecated macro, can be removed once minimum Qt is at least 6.3.0. | ||
| #if (QT_VERSION >= QT_VERSION_CHECK(6, 3, 0)) |
There was a problem hiding this comment.
The minimum supported Qt version remains 6.2 for now.
There was a problem hiding this comment.
I couldn't find where 6.2 was actually being tested against in the CI? Maybe it is a good time to bump the minimum supported version?
There was a problem hiding this comment.
6.7 was the earliest I could find?
There was a problem hiding this comment.
Maybe it is a good time to bump the minimum supported version?
We still support Ubuntu 22.04: https://packages.ubuntu.com/jammy/qt6-base-dev.
There was a problem hiding this comment.
note: https://github.com/bitcoin-core/gui/actions/runs/18416608653/job/52481652961
only failure - which suggests the tests aren't actually testing qt version <= 6.2
3 participants
No description provided.