feat(qt): Port win_taskbar_progress to Qt6 #215
Draft
+185
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think this would be easier to review if the Qt6 depends changes were split to a separate PR, and the fixups squashed. |
kwsantiago
force-pushed
the
kwsantiago/191-win-taskbar-progress-qt6
branch
from
3c0a6ca to
9757d00
Compare
This was referenced Nov 5, 2025
Author
|
I've split this PR as requested:
|
Collaborator
|
My thought was more of having this PR just port win_taskbar_progress to native Windows, and have the Qt6 PR independently change depends builds, neither depending on each other. |
kwsantiago
force-pushed
the
kwsantiago/191-win-taskbar-progress-qt6
branch
from
9757d00 to
8986737
Compare
Author
|
Gotcha @luke-jr I've updated both PRs to reflect. |
luke-jr
reviewed
Nov 7, 2025
luke-jr
requested changes
Nov 7, 2025
kwsantiago
force-pushed
the
kwsantiago/191-win-taskbar-progress-qt6
branch
2 times, most recently
from
bdc4742 to
52502ef
Compare
kwsantiago
force-pushed
the
kwsantiago/191-win-taskbar-progress-qt6
branch
from
52502ef to
0dc86b2
Compare
luke-jr
requested changes
Nov 7, 2025
kwsantiago
force-pushed
the
kwsantiago/191-win-taskbar-progress-qt6
branch
from
0dc86b2 to
b895717
Compare
kwsantiago
force-pushed
the
kwsantiago/191-win-taskbar-progress-qt6
branch
from
b895717 to
c527b35
Compare
luke-jr
requested changes
Nov 8, 2025
Comment on lines
371
to
372
| "Qt${WITH_QT_VERSION}::WinExtras" | ||
| $<$<PLATFORM_ID:Windows>:dwmapi> |
Comment on lines
+260
to
+261
| $<$<AND:$<PLATFORM_ID:Windows>,$<BOOL:${BITCOIN_QT_WIN_TASKBAR}>>:wintaskbarprogress.cpp> | ||
| $<$<AND:$<PLATFORM_ID:Windows>,$<BOOL:${BITCOIN_QT_WIN_TASKBAR}>>:wintaskbarprogress.h> |
Collaborator
There was a problem hiding this comment.
Probably cleaner to just move this below with the if(WITH_TASKBAR_PROGRESS)?
Comment on lines
+12
to
+13
| #pragma comment(lib, "ole32.lib") | ||
| #pragma comment(lib, "shell32.lib") |
Collaborator
There was a problem hiding this comment.
This shouldn't be necessary, right?
| QWindow* m_window = nullptr; | ||
| int m_value = 0; | ||
| bool m_visible = false; | ||
| void* m_taskbar_button = nullptr; // ITaskbarList3* |
Collaborator
There was a problem hiding this comment.
Why is this a void*? Better to avoid casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace QtWinExtras (removed in Qt6) with native Windows ITaskbarList3 COM API, making the Windows taskbar progress feature compatible with both Qt5 and Qt6.
Closes #191
Changes
Implementation
The new
WinTaskbarProgressclass uses WindowsITaskbarList3directly, maintaining full feature parity with the Qt5 implementation while working with both Qt5 and Qt6.