Remove triton.ops, copy necessary bits here #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Triton upstream removed `triton.ops` and moved it to a semi-unmaintained `kernels` repo. Since all that's needed here is the perf model, just add those bits here.
akx
reviewed
Nov 18, 2024
| @@ -0,0 +1,208 @@ | |||
| import functools | |||
There was a problem hiding this comment.
This file should have a reference comment to the triton upstream it was copies from, as well as suitable license attribution.
Suggested change
| import functools | |
| # Adapted from https://github.com/triton-lang/kernels/blob/eeeebdd8be7d13629de22d600621e6234057eed3/kernels/matmul_perf_model.py | |
| # https://github.com/triton-lang/kernels is licensed under the MIT License. | |
| import functools |
should probably be enough.
This was referenced Nov 24, 2024
|
Hi @akx, any chance to get this merged? Thanks! |
|
@bertmaher Sorry, I don't have merge privileges here, just a humble contributor. Cc @matthewdouglas :) |
matthewdouglas
approved these changes
Dec 17, 2024
|
LGTM, thanks! |
pnunna93
pushed a commit
to ROCm/bitsandbytes
that referenced
this pull request
Feb 20, 2025
…1413) * Remove triton.ops, copy necessary bits here Summary: Triton upstream removed `triton.ops` and moved it to a semi-unmaintained `kernels` repo. Since all that's needed here is the perf model, just add those bits here. * Add source reference/license comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Triton upstream removed
triton.opsand moved it to a semi-unmaintainedkernelsrepo. Since all that's needed here is the perf model, just add those bits here.