add support for 64 block size on 32 warp size supported amd gpus #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I don't have the bandwidth to test this personally at the moment, so will defer to AMD team. Also I do not have any RDNA GPUs on hand. cc: @pnunna93 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
pnunna93
suggested changes
Sep 24, 2025
|
Hi @electron271 |
matthewdouglas
previously approved these changes
Oct 3, 2025
|
will look through all this soon, sorry have been somewhat busy |
Reuse BNB_WARP_SIZE macro
sstamenk
reviewed
Oct 20, 2025
| #define DENORM 1.0f/127.0f | ||
| #define MAX_SPARSE_COUNT 32 | ||
| #define SMEM_SIZE 8*256 | ||
| #if defined(__GFX9__) |
There was a problem hiding this comment.
This is unused now and can be removed.
sstamenk
reviewed
Oct 20, 2025
|
|
||
| #define ERR_NOT_IMPLEMENTED 100 | ||
|
|
||
| #if defined(__GFX9__) |
There was a problem hiding this comment.
This is unused now and can be removed.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocm.docs.amd.com/en/latest/reference/gpu-arch-specs.html most non instinct gpus support 32 warp size
tested on RX 9070 XT, looking into getting this tested on amd instinct accelerators to ensure gpus with 64 warp size still work