Fix for warpSize deprecation in ROCm 7.0 #1762
Merged
+66
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stogram-scatter Remove estimate quantiles histogram scatter
Update docstring for blocksize default on ROCm
Remove support for 6.0 and below
warpSize is being made non constexpr in ROCm 7.0
Ifu rocm enabled 09 23 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
matthewdouglas
merged commit b72b766
into
bitsandbytes-foundation:main
50 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warpSize is removed as constant from ROCm 7.0 (https://rocm.docs.amd.com/projects/HIP/en/latest/hip-7-changes.html#warpsize-change). This PR updates warpSize usage in bitsandbytes with compile directives to avoid build errors.
It also ports some of the latest kernel changes onto ROCm.