-
-
Notifications
You must be signed in to change notification settings - Fork 792
[NVIDIA] Add Orin, GB300, Spark Support #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
# CUDA 12.8+: Add sm100 and sm120; remove < sm70 to align with PyTorch 2.8+cu128 minimum | ||
[[ "${cuda_version}" == 12.8.* || "${cuda_version}" == 12.9.* ]] && build_capability="70;75;80;86;89;90;100;120" | ||
[[ "${cuda_version}" == 12.8.* || "${cuda_version}" == 12.9.* ]] && build_capability="70;75;80;87;86;89;90;100;120;121" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that Orin (sm87) and Spark (GB10, sm121) are only available on aarch64 platforms, so we shouldn't need to do this for x86-64.
|
||
# CUDA 13.0+: Add sm100/sm110/sm120 | ||
[[ "${cuda_version}" == 13.*.* ]] && build_capability="75;80;90;100;110;120" | ||
[[ "${cuda_version}" == 13.*.* ]] && build_capability="75;80;87;90;100;103;110;120;121" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected building for sm80, sm100, and sm120 to cover this as we don't use any specific features in sm87/sm103/sm121 yet. Is it not working today? Can you clarify on the benefit of adding these targets? I assume maybe just some performance optimizations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t know that. That is fine. Closing
|
||
# CUDA 13.0+: Remove < sm75 to align with PyTorch 2.9+cu130 minimum | ||
[[ "${cuda_version}" == 13.*.* ]] && build_capability="75;80;86;89;90;100;120" | ||
[[ "${cuda_version}" == 13.*.* ]] && build_capability="75;80;87;90;100;103;110;120;121" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment on sm87, sm110, sm121 being exclusive to aarch64.
I think we should keep sm86/sm89, and maybe consider adding sm103.
[[ "${cuda_version}" == 13.*.* ]] && build_capability="75;80;87;90;100;103;110;120;121" | |
[[ "${cuda_version}" == 13.*.* ]] && build_capability="75;80;86;89;90;100;103;120" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
No description provided.