Initial SPIRV no_std implementation #85
Merged
+94
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repi
changed the title
5 tasks
bjorn3
reviewed
Oct 26, 2020
khyperia
reviewed
Oct 26, 2020
bitshifter
reviewed
Oct 26, 2020
bitshifter
reviewed
Oct 26, 2020
Owner
|
I'm not sure it's of use to your SPIRV efforts but I fixed It requires |
Contributor
Author
|
@bitshifter thanks will check out! |
bitshifter
reviewed
Nov 24, 2020
Owner
bitshifter
left a comment
bitshifter
left a comment
There was a problem hiding this comment.
What do you mean I can't printf debug on the GPU :)
Contributor
Author
|
Wooho! 🎉🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first early test implementation for our new
spriv-unknown-unknowntarget that we have in our Rust GPU compiler backend and to bring upglamto support it, this overall effort is tracked and discussed in EmbarkStudios/rust-gpu#134We currently require
no_stdso this enablesno_std(related discussion: #5) when building glam for that target but then defines a small extension trait to bring in thef32functionality fromstd. This is right now defined directly inglamhere in a separatespirv.rsand is missing some intrinsic liketanthat we'll need we'll need to add to Rust core.Pretty happy that did get most things to compile this way, but some glam functionality has been stubbed out. Not too complex.
Expect this to live as a draft PR here for quite a while until we have settled on some of these intrinsics implementations, where they should live, and fixed some compiler backend issues with the this for now also. But having it as an open draft PR makes it more visible and easier to discuss approaches.