Fix source of sonar scan failure #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantyk
requested review from
andrian-sevastyanov,
devmehtabd,
dterrybd and
gopannabd
shantyk
changed the title
Contributor
|
The child class has planned changes. Hence, it is fine to rename the methods in the child to address the flag. |
gopannabd
approved these changes
Mar 21, 2024
shantyk
changed the title
devmehtabd
approved these changes
Mar 21, 2024
dterrybd
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is the failing sonar cloud find:
The best thing to do would be to update the methods' to be protected instead of private in the parent class. However the parent class is inside integration-bdio library which would trigger a series of library changes/releases. Wanted to get thoughts on this fix from team, though this does introduce tech debt it would expedite our code freeze. Alternatively I can go ahead and update the library code, release new version (along with any other downstream library version updates) and prevent tech debt.Confirmed with @gopannabd that the affected class has additional tech debt that will need to be addressed, adding this on to that ticket (IDETECT-4278).