OTWO-4267 Configured installation of multiple SCMs in travis builds #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/unit/hg_push_test.rb
Outdated
| assert HgAdapter.new(:url => "/Users/robin/src").local? | ||
| assert HgAdapter.new(:url => "file:///Users/robin/src").local? | ||
| assert HgAdapter.new(:url => "ssh://#{Socket.gethostname}/Users/robin/src").local? | ||
| # assert HgAdapter.new(:url => "ssh://#{Socket.gethostname}/Users/robin/src").local? |
There was a problem hiding this comment.
Since we are planning to fix these tests in a different ticket, keep them uncommented. We shouldn't ever comment out failing tests.
If ohloh_scm changes the encoding, original characters might be lost. Users might be aware of the correct encoding and may wish to handle it accordingly.
Undid previous lib changes made just to make test pass on travis.
|
LGTM |
notalex
force-pushed
the
OTWO-4267
branch
2 times, most recently
from
7b03f9e to
91181b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured installation of multiple SCMs in travis builds and fixed the failing test cases except ssh related tests.