Get SVN tags list using ls instead of log #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
fix_svn_tags
branch
10 times, most recently
from
11ed2f0 to
09ccf56
Compare
lib/ohloh_scm/adapters/svn/misc.rb
Outdated
| tag_string.match(/\/tags\/(.+) \(from .+:(\d+)\)\Z/)[1..2] | ||
| end | ||
| commit, tag_name = tag_string.split(/\s/) | ||
| next if tag_name == './' |
There was a problem hiding this comment.
Some results are duplicates and have no commit reference:
$ svn ls -v https://svn.apache.org/repos/asf/httpd/httpd/tags/ | tr -s ' ' ' ' | cut -d ' ' -f2,7
wrowe
...
396066 2.2.2/
jim
wrowe
wrowe
wrowe
wrowe
wrowe
jim
wrowe
wrowe
wrowe
426151 2.2.3/
wrowe
wrowe
493425 2.2.4/
564746 2.2.5/
572801 2.2.6/
608857 2.2.7/
610841 2.2.8/
666274 2.2.9/
724095 2.3.0/
730918 2.3.1/
jim
jim
jim
jim
...
There was a problem hiding this comment.
I believe we need to fix | tr -s ' ' ' ' | cut -d ' ' -f2,7. Are we purposefully skipping tags ending with more than 1 decimal point?
$ svn ls -v https://svn.apache.org/repos/asf/httpd/httpd/tags/
...
396066 pquerna Apr 22 2006 2.2.2/
1163057 jim Aug 30 2011 2.2.20/
1167190 wrowe Sep 09 2011 2.2.21/
1235965 wrowe Jan 26 2012 2.2.22/
1375704 wrowe Aug 21 2012 2.2.23/
1447538 wrowe Feb 19 2013 2.2.24/
1497914 wrowe Jun 29 2013 2.2.25/
1541605 jim Nov 13 2013 2.2.26/
1577278 wrowe Mar 14 2014 2.2.27/
1619760 wrowe Aug 22 2014 2.2.28/
1619850 wrowe Aug 22 2014 2.2.29/
426151 wrowe Jul 27 2006 2.2.3/
1690340 wrowe Jul 11 2015 2.2.30/
1691245 wrowe Jul 15 2015 2.2.31/
493425 wrowe Jan 06 2007 2.2.4/
564746 jim Aug 11 2007 2.2.5/
572801 jim Sep 05 2007 2.2.6/
608857 jim Jan 04 2008 2.2.7/
610841 jim Jan 10 2008 2.2.8/
666274 jim Jun 11 2008 2.2.9/
724095 pquerna Dec 07 2008 2.3.0/
730918 pquerna Jan 03 2009 2.3.1/
1045184 jim Dec 13 2010 2.3.10/
1075920 jim Mar 01 2011 2.3.11/
1101854 jim May 11 2011 2.3.12/
1140732 jim Jun 28 2011 2.3.13/
...
ba4a823 to
c336745
Compare
lib/ohloh_scm/adapters/svn/misc.rb
Outdated
| tag_string.match(/\/tags\/(.+) \(from .+:(\d+)\)\Z/)[1..2] | ||
| end | ||
| entries = tag_string.split(' ') | ||
| [entries.first, entries.last] |
There was a problem hiding this comment.
We can use
tag_string.split(' ').values_at(0, -1)
ghost
force-pushed
the
fix_svn_tags
branch
3 times, most recently
from
bba4271 to
c7a4e67
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.