feat: redesign payment success screen #3436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiankii
changed the title
|
This is ready for review @dolcalmi |
…ayment-success-screen
…ayment-success-screen
dolcalmi
requested changes
Oct 1, 2025
| }, | ||
| ) => { | ||
| const { maxLength, maxResultLeft, maxResultRight } = options | ||
| if (typeof text !== "string") return "" |
There was a problem hiding this comment.
this is not necessary we are using typescript and in theory should be detected in compile time
| if (typeof text !== "string") return "" | ||
| if (text.length <= maxLength) return text | ||
|
|
||
| if (typeof maxResultLeft === "number" && typeof maxResultRight === "number") { |
| // Shorten a long text by inserting "..." in the middle, keeping the ends visible. | ||
| export const ellipsizeMiddle = ( | ||
| text: string, | ||
| options: { |
| } | ||
|
|
||
| // Shorten a long text by inserting "..." in the middle, keeping the ends visible. | ||
| export const ellipsizeMiddle = ( |
| } | ||
|
|
||
| // e.g. 1747691078 -> "2025-05-19 15:44" | ||
| export function formatUnixTimestampYMDHM(timestampInSeconds: number) { |
There was a problem hiding this comment.
is this not like .toISOString ?
new Date(1747691078 * 1000).toISOString().slice(0, 16).replace('T', ' ')
|
|
||
| const useStyles = makeStyles(({ colors }) => ({ | ||
| contentContainer: { | ||
| headerContainer: { |
There was a problem hiding this comment.
please validate if we can use relative values (i.e %)
| <View> | ||
| <Text style={styles.inputStyle} type={"p3"}> | ||
| {textData.text} | ||
| {textData.url && " "} |
There was a problem hiding this comment.
what is the purpose of this?
| url?: string | ||
| } | ||
|
|
||
| export const FieldWithEvent = ({ title, value, subValue }: FieldWithEventProps) => { |
| </> | ||
| )} | ||
| <View style={styles.fieldContainer}> | ||
| <FieldWithEvent title={title} value={text!} subValue={subText} /> |
There was a problem hiding this comment.
please be consistent subValue={subText}
There was a problem hiding this comment.
is not missing the new keys?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new payment success screen will have more details and a Share action.