feat: add stablesats quotes graphql endpoints #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolcalmi
requested changes
Sep 1, 2025
Comment on lines
12
to
17
| export class DealerQuotesAppError extends DealerQuoteServiceError { | ||
| level = ErrorLevel.Critical | ||
| } | ||
| export class DealerQuotesServerError extends DealerQuoteServiceError { | ||
| level = ErrorLevel.Critical | ||
| } |
There was a problem hiding this comment.
this does not mean nothing.. can you create more specific errors?
There was a problem hiding this comment.
As you stated on call, i re-named the dealer-quote service name to just quotes, now you can see the new and more verbose error pattern matching in core/api/src/domain/quotes/errors.ts and in core/api/src/services/quotes/quotes.ts as such:
const handleDealerErrors = (err: Error | string | unknown) => {
const errMsg = parseErrorMessageFromUnknown(err)
const match = (knownErrDetail: RegExp): boolean => knownErrDetail.test(errMsg)
switch (true) {
case match(KnownDealerErrorDetails.NoConnection):
return new NoConnectionToQuotesError(errMsg)
case match(KnownDealerErrorDetails.QuotesExchangePrice):
return new QuotesExchangePriceError(errMsg)
case match(KnownDealerErrorDetails.QuotesLedgerError):
return new QuotesLedgerError(errMsg)
case match(KnownDealerErrorDetails.QuotesEntityError):
return new QuotesEntityError(errMsg)
case match(KnownDealerErrorDetails.QuotesAlreadyAcceptedError):
return new QuotesAlreadyAcceptedError(errMsg)
case match(KnownDealerErrorDetails.QuotesExpiredError):
return new QuotesExpiredError(errMsg)
case match(KnownDealerErrorDetails.QuotesCouldNotParseIdError):
return new QuotesCouldNotParseIdError(errMsg)
case match(KnownDealerErrorDetails.QuotesServer):
return new QuotesServerError(errMsg)
default:
return new UnknownQuotesServiceError(errMsg)
}
}
export const KnownDealerErrorDetails = {
NoConnection: /No connection established/,
QuotesExchangePrice:
/(?:StalePrice: last update was at|No price data available|OrderBook:)/,
QuotesLedgerError: /Sqlx/,
QuotesEntityError: /EntityError/,
QuotesAlreadyAcceptedError: /already accepted/,
QuotesExpiredError: /Quote has expired/,
QuotesCouldNotParseIdError: /CouldNotParseIncomingUuid/,
QuotesServer: /QuotesServerError/,
} as const
bas4r
force-pushed
the
stablesats-quotes
branch
from
82c5831 to
7ea52e2
Compare
bas4r
changed the title
bas4r
force-pushed
the
stablesats-quotes
branch
3 times, most recently
from
8241198 to
ed018e8
Compare
bas4r
force-pushed
the
stablesats-quotes
branch
from
ed018e8 to
200b7f6
Compare
dolcalmi
requested changes
Sep 24, 2025
|
|
||
| let result | ||
|
|
||
| switch (quoteType) { |
There was a problem hiding this comment.
This logic is a symptom that the query is not designed properly. please make a proposal before implement it
Comment on lines
+11
to
+14
| walletId: { | ||
| type: GT.NonNull(WalletId), | ||
| description: "Wallet id of the requesting wallet", | ||
| }, |
There was a problem hiding this comment.
It's authorized on wallet level and without providing walletId, it automatically returns error missing walletId.
Comment on lines
+19
to
+25
| export class QuotesEntityError extends QuotesServiceError { | ||
| level = ErrorLevel.Critical | ||
| } | ||
|
|
||
| export class QuotesLedgerError extends QuotesServiceError { | ||
| level = ErrorLevel.Critical | ||
| } |
There was a problem hiding this comment.
remember this is the domain of the core, not stablesats
Comment on lines
9
to
11
| if (!quoteId || typeof quoteId !== "string") { | ||
| return new Error("Invalid quote ID provided") | ||
| } |
There was a problem hiding this comment.
you need to create a checkedToQuoteId in domain also please dont use generic errors in app layer
bas4r
force-pushed
the
stablesats-quotes
branch
from
50c097c to
f1e6c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.