feat: save ln address as contact #85

tiankii · 2025-05-07T19:51:07Z

Summary

This pull request refactors the way contacts are handled in the system. Previously, contacts were stored as an embedded array within the Account document. This implementation migrates contact data into a dedicated Contact collection, allowing for more flexible and scalable contact management.

Changes Introduced

Created a new Contact Mongoose model and schema
Migrated existing embedded contacts from Account.contacts[] into the new Contact collection
Refactored the codebase to persist, update, and query contacts through the new Contact collection
Updated GraphQL types and resolvers to support contactCreate mutation
Added e2e for the contact flow
Removed the deprecated contacts field from the Account schema

core/api/src/services/mongoose/schema.types.d.ts

core/api/src/services/mongoose/schema.ts

core/api/src/domain/errors.ts

core/api/src/graphql/public/types/payload/contact-create.ts

core/api/src/app/contacts/contact-create.ts

core/api/src/app/contacts/intraledger-contact-create.ts

bats/helpers/user.bash

dolcalmi

looks good, just minor changes

core/api/src/graphql/public/types/object/user.ts

core/api/src/services/mongoose/contacts.ts

core/api/src/migrations/20250507231004-migrate-contacts-to-collection.ts

core/api/src/graphql/public/root/mutation/contact-create.ts

core/api/src/domain/errors.ts

core/api/src/app/accounts/get-contacts-by-account.ts

core/api/src/app/accounts/create-contact.ts

esaugomez31 · 2025-07-07T15:19:48Z

@dolcalmi The e2e and integration tests should be run again, because the failures do not seem to be related to the PR

core/api/src/app/accounts/create-contact.ts

core/api/src/app/accounts/get-contacts-by-account.ts

core/api/src/app/accounts/update-contact-alias.ts

bats/core/api/contact.bats

core/api/src/app/accounts/get-contacts-by-account.ts

core/api/src/domain/contacts/index.ts

…contacts collection

…ection migration

github-actions bot added dashboard consent pay map core labels May 7, 2025

tiankii marked this pull request as ready for review May 14, 2025 22:33

dolcalmi requested changes Jun 18, 2025

View reviewed changes

tiankii requested a review from dolcalmi July 1, 2025 23:14

dolcalmi requested changes Jul 1, 2025

View reviewed changes

tiankii requested a review from dolcalmi July 3, 2025 03:17

dolcalmi requested changes Jul 15, 2025

View reviewed changes

tiankii force-pushed the feat--save-ln-address-as-contact branch from c6c316b to 84525cd Compare July 17, 2025 17:34

tiankii requested a review from dolcalmi July 17, 2025 17:52

dolcalmi requested a review from esaugomez31 July 23, 2025 01:14

esaugomez31 approved these changes Jul 24, 2025

View reviewed changes

esaugomez31 added 14 commits July 29, 2025 11:42

feat(core): add ContactsRepository with persist, find and update methods

c6c3c6e

chore(core|services): repository function requesting object parameters

6366a2f

chore: refactored contact collection

5011aea

feat: graphql accountContactUpsert mutation, initial version

4f53a40

chore: file to updated and add contact renamed

757d023

refactor: move contact storage from accounts collection to dedicated …

3f160cd

…contacts collection

feat(core): migrate-contacts-to-collection

325275b

test(core|e2e): test upsert contact mutation

dacd20c

chore: remove personal data

01d3c60

chore: renaming mutation accountContactUpsert to contactCreate

599c4ea

chore: renamin contact with upsert references

6efa7d7

refactor: referencing the contacts collection in accounts object

fe7d51c

refactor(account): remove contacts field from Account schema

a968a8e

fix(migrations): avoid redeclaration of randomUUID in contact to coll…

7667353

…ection migration

This was referenced Nov 5, 2025

chore(deps): bump-dashboard-image-758ad72 blinkbitcoin/charts#8446

Open

chore(deps): bump-map-image-758ad72 blinkbitcoin/charts#8448

Open

feat: save ln address as contact #85

feat: save ln address as contact #85

Uh oh!

Conversation

tiankii commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Introduced

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dolcalmi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

esaugomez31 commented Jul 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tiankii commented May 7, 2025 •

edited

Loading