-
Notifications
You must be signed in to change notification settings - Fork 179
✅ Update Github action workflow #3533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will conflict with the work done in #3530, so it will need to be rebased once that has been merged (which I cannot do yet due to a missing review). |
No problem, I have read the #3530 PR. |
d133e7b
to
c09162d
Compare
@bobvandevijver This PR is rebased. But, for testing, it's more than using the lower-supported version. IMHO, PHP 8.0 because nobody uses Bolt with PHP 7.x. The CI increased PHP 7.x usage in the last day. Stats source: https://packagist.org/packages/bolt/core/php-stats#5 |
For PHP version I'm for dropping all unsupported PHP versions with 5.3.0, making the project >=8.1. |
Bolt follows semantic versioning and this change in a minor version is not allowed, only in a major. Symfony has changed the minimum PHP version required to 8.1 when releasing Symfony 6.1. The Symfony community has been angry. I prefer to keep PHP 7.2 for the 5.x branch and bump to PHP 8.1 with Bolt 6.x and Symfony 7.4. The change will be required by Symfony. Where can you discuss the roadmap? |
See this excellent summary from doctrine. Dropping support for a PHP version is not considered a BC break (which is also why Symfony did it) and can thus be done in a minor. Especially if we're only dropping versions that cannot be used safely anymore.
Well, not here, because this PR is already closed. Either in a new PR that proposes, or an issue/discussion for the subject. See #3538 for the one I made. |
This PR updates the GitHub Action workflows to use the latest versions of the actions and their specific configuration.
shivammathur/setup-php@v2
installs the latest version of composer which removes the update actions.It also installs the Symfony client which can be used as a web server for testing.
This removes the
symfony/web-server-bundle
dependency.