Skip to content

Conversation

macintoshplus
Copy link
Contributor

This PR updates the GitHub Action workflows to use the latest versions of the actions and their specific configuration.

shivammathur/setup-php@v2 installs the latest version of composer which removes the update actions.

It also installs the Symfony client which can be used as a web server for testing.

This removes the symfony/web-server-bundle dependency.

@macintoshplus macintoshplus mentioned this pull request Mar 6, 2025
@bobvandevijver
Copy link
Member

This will conflict with the work done in #3530, so it will need to be rebased once that has been merged (which I cannot do yet due to a missing review).

@macintoshplus
Copy link
Contributor Author

No problem, I have read the #3530 PR.

@macintoshplus
Copy link
Contributor Author

@bobvandevijver This PR is rebased. But, for testing, it's more than using the lower-supported version.

IMHO, PHP 8.0 because nobody uses Bolt with PHP 7.x. The CI increased PHP 7.x usage in the last day.

image

Stats source: https://packagist.org/packages/bolt/core/php-stats#5

@bobvandevijver
Copy link
Member

bobvandevijver commented Mar 6, 2025

For PHP version I'm for dropping all unsupported PHP versions with 5.3.0, making the project >=8.1.

@bobvandevijver bobvandevijver merged commit aee9f08 into bolt:master Mar 6, 2025
16 checks passed
@macintoshplus
Copy link
Contributor Author

For PHP version I'm for dropping all unsupported PHP versions with 5.3.0, making the project >=8.1.

Bolt follows semantic versioning and this change in a minor version is not allowed, only in a major.

Symfony has changed the minimum PHP version required to 8.1 when releasing Symfony 6.1. The Symfony community has been angry.

I prefer to keep PHP 7.2 for the 5.x branch and bump to PHP 8.1 with Bolt 6.x and Symfony 7.4. The change will be required by Symfony.

Where can you discuss the roadmap?

@macintoshplus macintoshplus deleted the upgrade_workflow branch March 6, 2025 22:13
@bobvandevijver
Copy link
Member

bobvandevijver commented Mar 6, 2025

See this excellent summary from doctrine. Dropping support for a PHP version is not considered a BC break (which is also why Symfony did it) and can thus be done in a minor. Especially if we're only dropping versions that cannot be used safely anymore.

Where can you discuss the roadmap?

Well, not here, because this PR is already closed. Either in a new PR that proposes, or an issue/discussion for the subject. See #3538 for the one I made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants