Skip to content

Conversation

@macintoshplus
Copy link
Contributor

Replace dependency tightenco/collect by illuminate/collection

See issue #3551

@macintoshplus macintoshplus added the dependencies Pull requests that update a dependency file label Mar 11, 2025
@macintoshplus macintoshplus force-pushed the issue_3551_replace_collect branch from 0486328 to 8fc938c Compare March 12, 2025 09:44
Copy link
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a BC break due to the namespace change. We need at the very least a note in the release document, as to what has changed, and I am at doubt whether we can merge this for 5.3.

@macintoshplus
Copy link
Contributor Author

This is a BC break due to the namespace change. We need at the very least a note in the release document, as to what has changed, and I am at doubt whether we can merge this for 5.3.

Yes, but the update to Symfony 7 must introduce other namespace changes or BC break.

From annotation to attribute is a BR Break?

For Bolt 5.3, if this dependency is not migrated, the latest Symfony version is 6.4 from dependency requirements.

@bobvandevijver
Copy link
Member

5.3 won't be getting a Symfony upgrade for the same reason.

@macintoshplus
Copy link
Contributor Author

Ok, this is why Symfony dependencies were removed from ticket 3551.

It's Okay; all PR with BC Break can wait until after Bolt 5.3 to go to Bolt 6. Or a branch for Bolt 6 can be opened before Bolt 5.3 is released?

@macintoshplus macintoshplus force-pushed the issue_3551_replace_collect branch from 53692ee to d80ed0d Compare March 14, 2025 10:33
@bobvandevijver
Copy link
Member

The first focus is 5.3, and we can do for that without breaking BC.
The path for 6.0 is still to be discussed, and as I will be on holiday a final decision will be postponed until May.

@macintoshplus macintoshplus changed the title ⬆️ Replace dependency tightenco/collect by illuminate/collect… ⬆️ 💥 Replace dependency tightenco/collect by illuminate/collect… Mar 14, 2025
@bobvandevijver bobvandevijver merged commit 7d1e98e into main Jul 20, 2025
60 of 66 checks passed
@bobvandevijver bobvandevijver deleted the issue_3551_replace_collect branch July 20, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants