Skip to content

Conversation

@jeking3
Copy link
Contributor

@jeking3 jeking3 commented Apr 26, 2019

Reasons for this:

  1. The headers in boostorg/disjoint_sets have a dependency on graph, causing a cycle; this resolves the cycle.
  2. Maintaining a repository for one class like disjoint_sets is unreasonable overhead.
  3. The only consumers of disjoint_sets are graph and graph_parallel, and graph_parallel depends on graph.

The disjoint_sets headers are still in boost/pending, as graph already has a number of these.
The history of the files in disjoint_sets has not been preserved (I believe this would require a rebase and force push to achieve, and does not seem worth the trouble it would cause).

Completing this work will require some coordination - pull requests after this will be:

  • Removing disjoint_sets from the superproject.
  • Removing disjoint_sets from the boostorg exceptions. cc: @pdimov

This may require an announcement for all developers so they can update their local sandboxes.

This fixes #113

@jeking3
Copy link
Contributor Author

jeking3 commented Apr 26, 2019

It was suggested on the boost mailing list that it is acceptable for the builds to be broken during the migration, since our multirepo layout does not handle this type of consolidation well. If you would consider merging this, I will submit a pull request into boostorg to remove disjoint_sets as a project. Things build locally with this PR in place and the original repository removed, and a clean build is performed.

@anadon
Copy link
Contributor

anadon commented May 2, 2019

@jzmaddock Can we try this out?

@jzmaddock jzmaddock merged commit a7896a7 into boostorg:develop May 2, 2019
@jzmaddock
Copy link
Contributor

Hopefully I've managed to coordinate these changes with disjoint_sets without breaking anything.... but we'll see!

@jeking3 jeking3 deleted the ingest-disjoint-sets branch May 2, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consume boostorg/disjoint_sets

3 participants