uniform method signature - core #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10
Make
methoduse the actual function type as its second parameter. I.e. what used to readmethod<Name(Parameters...), ReturnType, Registry>is nowmethod<Name, auto(Parameters...)->ReturnType, Registry>(ormethod<Name, ReturnType(Parameters...), Registry>). This aligns better with other constructs which work in terms of method-id then method-signature. It also better corresponds to the method-id's goal, which is to discriminate between different methods with the same signature.As for switching the macros to
BOOST_OPENMETHOD(id, (Args&&... args)->ReturnType), the idea is still being debated.