Bump containers-image-proxy, ocidir, oci-spec and composefs-rs #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first three are all entangled because of a messy oci-spec semver incompatibility youki-dev/oci-spec-rs#288 Bumping composefs-rs is just to avoid having two versions of the proxy in the lockfile. Closes: bootc-dev#1567 Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several key dependencies, including containers-image-proxy, ocidir, oci-spec, and composefs-rs, to resolve a semantic versioning incompatibility in oci-spec. The changes primarily involve adapting the codebase to the updated APIs of these dependencies, particularly handling Option types for image history. The modifications appear correct and necessary to align with the new dependency versions. I have one minor suggestion for code simplification.
jeckersb
approved these changes
Sep 4, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first three are all entangled because of a messy oci-spec semver incompatibility
youki-dev/oci-spec-rs#288
Bumping composefs-rs is just to avoid having two versions of the proxy in the lockfile.
Closes: #1567