Truncate body upload limit #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wagslane
commented
Dec 28, 2024
wagslane
commented
- typo
- truncate body upload, small typo fix
skovranek
reviewed
Dec 28, 2024
| if test.BodyContains != nil { | ||
| interpolated := checks.InterpolateVariables(*test.BodyContains, variables) | ||
| return fmt.Sprintf("Expecting JSON body to contain: %s", interpolated) | ||
| return fmt.Sprintf("Expecting body to contain: %s", interpolated) |
Member
There was a problem hiding this comment.
Also remove "JSON" from BodyContainsNone string on line 265? I can add this to my changes for new combined lesson type.
Member
Author
There was a problem hiding this comment.
Yeah if you can just throw that in that would be great, didn't see that one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.