Updates needed for polished v3.1 release code #349

gtiao · 2021-03-31T19:59:14Z

No description provided.

jkgoodrich

A couple small things

gnomad/utils/annotations.py

gnomad/utils/release.py

gnomad/utils/annotations.py

gnomad/utils/release.py

gnomad/utils/annotations.py

gnomad/utils/release.py

Co-authored-by: jkgoodrich <[email protected]>

…x_dict()

jkgoodrich

Sorry, many of these suggestions are to the code that I put in

gnomad/utils/release.py

Co-authored-by: jkgoodrich <[email protected]>

…nomad_methods into gt_v3.1_changes

Co-authored-by: jkgoodrich <[email protected]>

…nomad_methods into gt_v3.1_changes

jkgoodrich

Really tiny docstring things then I think it's good, but you will need to merge with master so the tests can run and this can be merged

gnomad/utils/annotations.py

gnomad/utils/release.py

jkgoodrich · 2021-04-21T16:43:56Z

Oh yeah, also add to change log the functions that were added

Co-authored-by: jkgoodrich <[email protected]>

jkgoodrich · 2021-04-23T17:04:37Z

looks like black needs to be run on one of the files

…nomad_methods into gt_v3.1_changes

jkgoodrich

lgtm

gtiao added 2 commits March 31, 2021 15:57

Updates needed for polished v3.1 release code

5a02fc7

Run Black

342faa9

gtiao requested a review from jkgoodrich March 31, 2021 20:08

Reformatting docstrings to pass PR build documentation check"

342bb8b

jkgoodrich requested changes Apr 1, 2021

View reviewed changes

gtiao added 3 commits April 9, 2021 11:52

Creating release.py to house general-use release functions

c8a13f7

Addressed Julia's PR comments

6132fe8

Add missing imports found during PyLint check

62fde8c

jkgoodrich self-requested a review April 15, 2021 13:48

Add missing import statement

edd0967

jkgoodrich requested changes Apr 16, 2021

View reviewed changes

gtiao and others added 5 commits April 16, 2021 16:00

Moving set_female_y_metrics_to_na() function to release.py

c2e7d38

Update gnomad/utils/annotations.py

667ffb4

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

b16ea04

Co-authored-by: jkgoodrich <[email protected]>

Addressing Julia's PR comments

9fd9a19

Updating make_faf_index_dict() code to match style for make_freq_inde…

9202d59

…x_dict()

jkgoodrich requested changes Apr 16, 2021

View reviewed changes

gtiao and others added 13 commits April 21, 2021 11:31

Update gnomad/utils/release.py

a3778c6

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

4457b03

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

d9f8367

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

109c999

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

13beea3

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

8ccb770

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

63ab349

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

1b41b2d

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

a413c4a

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

b22a3bb

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

5af023b

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

7b92bc2

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

4f8caf9

Co-authored-by: jkgoodrich <[email protected]>

gtiao and others added 4 commits April 21, 2021 11:49

Tweaking code to address Julia's PR comments

e938866

Merge branch 'gt_v3.1_changes' of https://github.com/broadinstitute/g…

53b8d29

…nomad_methods into gt_v3.1_changes

Update gnomad/utils/release.py

d9edbd2

Co-authored-by: jkgoodrich <[email protected]>

Merge branch 'gt_v3.1_changes' of https://github.com/broadinstitute/g…

4e18dfd

…nomad_methods into gt_v3.1_changes

gtiao requested a review from jkgoodrich April 21, 2021 16:18

jkgoodrich approved these changes Apr 21, 2021

View reviewed changes

gnomad/utils/annotations.py Outdated Show resolved Hide resolved

gnomad/utils/annotations.py Outdated Show resolved Hide resolved

gnomad/utils/release.py Outdated Show resolved Hide resolved

gnomad/utils/release.py Outdated Show resolved Hide resolved

gtiao and others added 6 commits April 21, 2021 12:59

Update gnomad/utils/annotations.py

0904f7f

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/annotations.py

0d400b3

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

44a41f3

Co-authored-by: jkgoodrich <[email protected]>

Update gnomad/utils/release.py

791c476

Co-authored-by: jkgoodrich <[email protected]>

Merge branch 'master' into gt_v3.1_changes

56adae2

Fixing indent issue identified by PyLint

c62af51

gtiao added 3 commits April 23, 2021 15:13

Merge branch 'gt_v3.1_changes' of https://github.com/broadinstitute/g…

d29041e

…nomad_methods into gt_v3.1_changes

Ran Black

dcf575a

Listing new functions in changelog

ad250d4

gtiao requested a review from jkgoodrich April 23, 2021 19:35

jkgoodrich added 2 commits April 23, 2021 14:17

Run black and remove blank lines

408ee90

Add `# noqa: D100 to release.py

f29eee9

jkgoodrich approved these changes Apr 23, 2021

View reviewed changes

gtiao merged commit 23e0a58 into master Apr 23, 2021

gtiao deleted the gt_v3.1_changes branch April 23, 2021 20:46

Updates needed for polished v3.1 release code #349

Updates needed for polished v3.1 release code #349

Uh oh!

Conversation

gtiao commented Mar 31, 2021

Uh oh!

jkgoodrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkgoodrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkgoodrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkgoodrich commented Apr 21, 2021

Uh oh!

jkgoodrich commented Apr 23, 2021

Uh oh!

jkgoodrich left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants