Skip to content

Update to new RouterAsyncFS interface in Hail 0.2.79 #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

Update to new RouterAsyncFS interface in Hail 0.2.79 #425

merged 1 commit into from
Dec 1, 2021

Conversation

@nawatts
Copy link
Contributor

@nawatts nawatts commented Nov 30, 2021

hail-is/hail#11063 changed the interface of RouterAsyncFS. filesystems must now be passed as a keyword argument.

@nawatts nawatts requested a review from klaricch November 30, 2021 14:43
@nawatts nawatts mentioned this pull request Nov 30, 2021
Merged
jkgoodrich
jkgoodrich approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkgoodrich jkgoodrich merged commit 914e1f7 into master Dec 1, 2021
@jkgoodrich jkgoodrich deleted the routerasyncfs-change branch December 1, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

@klaricch klaricch Awaiting requested review from klaricch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nawatts @jkgoodrich