Skip to content

Add bi_allelic_only and snv_only options to get_qc_mt #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2022
Merged

Add bi_allelic_only and snv_only options to get_qc_mt #471

merged 2 commits into from
Jul 25, 2022

Conversation

jkgoodrich
Copy link
Contributor

Allows for some additional QC MT options so that multi-allelic variants and indels can be included if wanted

@jkgoodrich jkgoodrich requested a review from mike-w-wilson July 25, 2022 16:27
mike-w-wilson
mike-w-wilson reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things: one is a small suggestion for the doctring and the other I cannot add in because the lines were not changed but bi_allelic_only and snv_only should also be added to the global annotations in L212

@jkgoodrich jkgoodrich requested a review from mike-w-wilson July 25, 2022 18:01
mike-w-wilson
mike-w-wilson approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkgoodrich jkgoodrich merged commit 7183c56 into main Jul 25, 2022
@jkgoodrich jkgoodrich deleted the jg/add_biallelic_option_to_qc_mt branch July 25, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-w-wilson mike-w-wilson mike-w-wilson approved these changes

Assignees

@mike-w-wilson mike-w-wilson

@jkgoodrich jkgoodrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkgoodrich @mike-w-wilson