Update some gnomAD resources from lists to version dictionaries #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkgoodrich
approved these changes
Mar 27, 2023
gnomad/resources/grch38/gnomad.py
Outdated
| "tgp", | ||
| "hgdp", | ||
| ], | ||
| "v4": ["ukb", "non-ukb", "non-topmed"], |
There was a problem hiding this comment.
Just confirming there is an intentional switch to - from _ I don't remember all thee fine details associated with that.
There was a problem hiding this comment.
Ah no good catch. The 4.3 vcf spec does not allow hyphens so underscores are better here to be consistent with the vcf. I took this straight from the v4 release HT schema but I'll update it there as well.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These resources were previously v3 specific. This update changes them to dictionaries where the key is the version and the value is a list.